fix issue #797 predict_file should be able to take in a dataframe #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the contribution @Abhishek-kumar0503 and sorry it didn't get reviewed. It looks like we had two competing PRs, were working on the other one, the other one was never finished, and we lost track of things. Unfortunately the predict_file has changed a lot in the last 11 months due to shifts in how we handle data loaders, so this PR is now well out of sync with the code base so I'm closing. If you're still interested in working on this ping #797 so that we can confirm that we still want/need this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve he main.deepforest.predict_file should be able to take in a dataframe, not just a csv file. #797